We are getting new uniforms and I am arguing with my director over wether we should get white or black shoes... What do y’all think? Which looks better? We will have black bibbers with a white and gold stripe.

Black! It looks more slick on turf . Plus if the weather gets weird where you live stepping in mud puddles would be a little bit easier - or just anything that will make a white shoe not white lol

Shoes should always match the bibbers

I'd say Black.
With white shoes against primarily black bibbers, it's easier to see any visual discrepancy from a general spectator/judge point of view, competitive or non.

However, If your group can pull off white shoes against black/white bibs, it would look cool, especially if it's clean. Which would give more of a motivation to pay attention to the minute details: matching/consistent step sizes, foot positions, forward/backwards slides, yatta yatta.

Think of blue stars this year. They had blue jean color pants and Tims colored shoes. IT WAS BAD

What about spats?

Well, the older Blue Star uniforms and most drum corps in the 70s-80s had white shoes with darker bibs.

White shoes or spats?